Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use num::Complex #9

Closed
JayKickliter opened this issue Jun 1, 2022 · 3 comments
Closed

Use num::Complex #9

JayKickliter opened this issue Jun 1, 2022 · 3 comments

Comments

@JayKickliter
Copy link

Using this library in another library can be difficult since it defines its own complex type. Since Rust doesn't have a Complex<T> it the standard library, num::Complex is the closest we have a to universal vocabulary type.
@At0micBee
Copy link
Owner

Hi,
True, I wanted to keep the library as monolithic as possible at first but I agree that it would offer better compatibility if using num-complex. I'll look into it in the near future.
Cheers!

@JayKickliter
Copy link
Author

JayKickliter commented Jun 1, 2022 •
edited

I wanted to keep the library as monolithic as possible

I 100% understand. And I'm extra fine with it when it's not part of the public API.

@At0micBee
Copy link
Owner

Version 0.5.0 is live using num_complex::Complex64 to replace the original Complex implementation.

All tests are passing, it should be all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JayKickliter @At0micBee