New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken image links in 3.3. Properties of natural signals #103
Comments
The images should be displaying now. I'll defer to @Atcold for the content suggestions, maybe you can make PR with these suggestions :) |
@feedthebeat90, sounds like a solid improvement. |
Sure, I think I should only add these lines below, however I do not have privileges to upload the images to the "..\images" folder
So I'll leave them here |
It would be great if you can follow GitHub's workflow to officially recommend changes! These graphics look great. Here's a guide on how to do this - you'll want to eventually open a Pull Request with these changes, that we can just merge with one click. |
@feedthebeat90, can you please send a PR? |
A few comments: Please check if the formatting for markdown looks good on the website. I cannot correctly preview changes from browser with the Preview Button. Also, move images 4(a) [Former 4, now with dimension addition] and 4(b) [New image for 0 padding] to the repo "./images/" folder , I don 't have privileges to do that (to the best of my knowledge), so I've used random URLs that Github generated to store images. Sorry for the delay, I've been out for the past few days! |
@feedthebeat90, you just need to place those images in the correct location. Let me know if you need any further instruction. |
Cool , I was not aware I could add files through forking + push + PR , my bad ! 😅 I tried a second time 😸 |
I'm not aware how you can add files in any alternative way 😳 |
Just by simple push or through web app upload but only if you are the owner ( I was working with a clone of your repo) , lol 😝 |
Hehe, nah, I prefer the terminal :) |
The following image links are broken:
See https://atcold.github.io/pytorch-Deep-Learning/en/week03/03-3/
I think the images were originally obtained from this presentation:
02 - CNN.pdf
See pages 10-11
Also, small suggestions:
Change Figure 4 to include R^7 and R^2 as in Slide 20 .
This would better match the text for Figure 4.
Include Figure (4b maybe?) with that on Slide 21 to show what Padding is doing
The text was updated successfully, but these errors were encountered: