Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image links in 3.3. Properties of natural signals #103

Closed
6 tasks done
feedthebeat90 opened this issue Mar 6, 2020 · 11 comments
Closed
6 tasks done

Broken image links in 3.3. Properties of natural signals #103

feedthebeat90 opened this issue Mar 6, 2020 · 11 comments

Comments

@feedthebeat90
Copy link
Contributor

feedthebeat90 commented Mar 6, 2020

The following image links are broken:

  • Figure 2(a)
  • Figure 2(b)
  • Figure 3(a)
  • Figure 3(b)

See https://atcold.github.io/pytorch-Deep-Learning/en/week03/03-3/

I think the images were originally obtained from this presentation:
02 - CNN.pdf

See pages 10-11


Also, small suggestions:

  • Change Figure 4 to include R^7 and R^2 as in Slide 20 .
    This would better match the text for Figure 4.

  • Include Figure (4b maybe?) with that on Slide 21 to show what Padding is doing

@ebetica
Copy link
Collaborator

ebetica commented Mar 7, 2020

The images should be displaying now. I'll defer to @Atcold for the content suggestions, maybe you can make PR with these suggestions :)

@Atcold
Copy link
Owner

Atcold commented Mar 8, 2020

@feedthebeat90, sounds like a solid improvement.
Can you send a PR with these augmentations?

@feedthebeat90
Copy link
Contributor Author

Sure, I think I should only add these lines below, however I do not have privileges to upload the images to the "..\images" folder


<center><img src="{{site.baseurl}}/images/week03/03-3/Figure_4a_kernels_on_1D_data.png" width="350px" /><br>
<b>Figure 4(a):</b> Kernels on 1D Data</center>

<center><img src="{{site.baseurl}}/images/week03/03-3/Figure_4b_zero_padding.png" width="350px" /><br>
<b>Figure 4(b):</b> Data with Zero Padding</center>


So I'll leave them here

Figure_4a_kernels_ on_1D_data

Figure_4b_zero_padding

@ebetica
Copy link
Collaborator

ebetica commented Mar 10, 2020

It would be great if you can follow GitHub's workflow to officially recommend changes! These graphics look great. Here's a guide on how to do this - you'll want to eventually open a Pull Request with these changes, that we can just merge with one click.

@Atcold
Copy link
Owner

Atcold commented Mar 14, 2020

@feedthebeat90, can you please send a PR?

@feedthebeat90
Copy link
Contributor Author

feedthebeat90 commented Mar 15, 2020

Done @ebetica @Atcold

A few comments:

Please check if the formatting for markdown looks good on the website. I cannot correctly preview changes from browser with the Preview Button.

Also, move images 4(a) [Former 4, now with dimension addition] and 4(b) [New image for 0 padding] to the repo "./images/" folder , I don 't have privileges to do that (to the best of my knowledge), so I've used random URLs that Github generated to store images.

Sorry for the delay, I've been out for the past few days!

@Atcold
Copy link
Owner

Atcold commented Mar 16, 2020

@feedthebeat90, you just need to place those images in the correct location.
Start by forking the current repo and clone it on your machine.
Add the images in the right location.
Use the same syntax shown here for inserting images in the markdown file.
git add <my_new_files> && git commit -m 'whatever' && git push
Then you do a pull request.

Let me know if you need any further instruction.

@feedthebeat90
Copy link
Contributor Author

Cool , I was not aware I could add files through forking + push + PR , my bad ! 😅

I tried a second time 😸

@Atcold
Copy link
Owner

Atcold commented Mar 16, 2020

I'm not aware how you can add files in any alternative way 😳

@feedthebeat90
Copy link
Contributor Author

I'm not aware how you can add files in any alternative way 😳

Just by simple push or through web app upload but only if you are the owner ( I was working with a clone of your repo) , lol 😝

@Atcold
Copy link
Owner

Atcold commented Mar 17, 2020

Hehe, nah, I prefer the terminal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants