-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] 10-2.md Self-Supervised Learning - ClusterFit and PIRL - spanish translation #597
Conversation
Spanish partial translation
Update translation
Sep 19 update
Finished file translated
You will need to add the path to this lesson (10-2) in this file as well Edit & Note for whoever merges this: This request was answered this other PR. Please merge that one together with this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Some of the suggestions are very trivial but I thought might improve readability. Nice translation anyway, it was really easy to read 👍
Change . by : Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are ready, except for the missing translation fragment that I upload in a moment.
Change "paper" and "papel" by "artículo" Add he missing translation fragment
Don't forget to put [ES] at the starting of the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update docs/_config.yml
as well.
Title translation Translation date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've updated docs/_config.yml
for you.
Attached is the Spanish translation of the 10-2.md. It is ready for review.