Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES] 10-2.md Self-Supervised Learning - ClusterFit and PIRL - spanish translation #597

Merged
merged 18 commits into from
Sep 23, 2020

Conversation

tiagogiraldo
Copy link
Contributor

Attached is the Spanish translation of the 10-2.md. It is ready for review.

docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
@xcastilla
Copy link
Contributor

xcastilla commented Sep 20, 2020

You will need to add the path to this lesson (10-2) in this file as well

Edit & Note for whoever merges this: This request was answered this other PR. Please merge that one together with this one.

Copy link
Contributor

@xcastilla xcastilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Some of the suggestions are very trivial but I thought might improve readability. Nice translation anyway, it was really easy to read 👍

tiagogiraldo and others added 8 commits September 20, 2020 11:48
Change . by :

Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Co-authored-by: Joaquim Castilla <xcastilla89@gmail.com>
Copy link
Contributor Author

@tiagogiraldo tiagogiraldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are ready, except for the missing translation fragment that I upload in a moment.

Change "paper" and "papel" by "artículo"
Add he missing translation fragment
@JonathanSum
Copy link
Contributor

Don't forget to put [ES] at the starting of the title.

Copy link
Contributor

@xcastilla xcastilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tiagogiraldo tiagogiraldo changed the title 10-2.md spanish translation [ES] 10-2.md Self-Supervised Learning - ClusterFit and PIRL - spanish translation Sep 21, 2020
Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update docs/_config.yml as well.

docs/es/week10/10-2.md Outdated Show resolved Hide resolved
docs/es/week10/10-2.md Outdated Show resolved Hide resolved
Title translation
Translation date
Copy link
Owner

@Atcold Atcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've updated docs/_config.yml for you.

@Atcold Atcold merged commit ae5152f into Atcold:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants