Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Singular value decomposition #40

Closed
zackmdavis opened this issue Apr 14, 2016 · 5 comments
Closed

Singular value decomposition #40

zackmdavis opened this issue Apr 14, 2016 · 5 comments

Comments

@zackmdavis
Copy link
Collaborator

There exist more efficient algorithms, but just using an eigenbasis of AᵀA is probably okay to start with? I understand this should also get us principal components analysis pretty easily.

@AtheMathmo
Copy link
Owner

I want to see SVD added for sure! Please feel free to work on it.

There currently exists some eigendecomposition. The eigenvalue decomposition works too but only for normal matrices with real eigenvalues. That in itself can probably be improved a lot.

See here for the current code. If you want to make any changes, or have suggestions, let me know!

Note: The current implementations are also just inefficient and should make use of the new MatrixSlice structs.

@AtheMathmo
Copy link
Owner

https://gist.github.com/zackmdavis/e65e295205aba03b548011c7401bf9ec

Posting this here for reference.

@AtheMathmo
Copy link
Owner

I've just merged the PR that resolves #64, sorry it took so long!. @zackmdavis - are you happy to pick up this issue again?

@AtheMathmo
Copy link
Owner

I found a UofTexas paper which provides pseudo code implementations of lots of SVD algorithms. These may be a little out of scope to begin with - but some of the simpler ones may still be worth a look.

@AtheMathmo
Copy link
Owner

This issue was moved to AtheMathmo/rulinalg#4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants