-
Notifications
You must be signed in to change notification settings - Fork 73
Websockets Support? #70
Comments
@bitdivision No plan yet |
Would you be open to accepting a pull request for it? I'm assuming that most of the effort at the moment is focused on async? If so should I be implementing this against one of those branches. Any suggestions as to how to go about this? |
@bitdivision Ofcourse. PRs are always welcome. All the work is happening on tokio2 branch. Please work on top of that. |
@tekjar - I tried to get in touch with you on gitter, but I don't think you saw it. I'm attempting to integrate https://github.com/snapview/tokio-tungstenite to provide websockets support and falling at the first hurdle. Perhaps @agalakhov could help with this too. What I'd like to do is add WebSocketStream to the NetworkStream enum, so that it can be used in the same way it currently is. I'm unable to do this as it doesn't support AsyncRead and I'm not sure how I would go about implementing Read for it. As far as I can tell, the WebSocketStream struct is essentially the equivalent of Framed, but obviously I'm unable to set decoders and encoders for it. I'll create an issue there too and see if they have any suggestions. Any ideas on how I can do this, or if I'm missing something obvious? |
@bitdivision My knowledge is almost close to zero w.r.t websockets. But connect_async seems to be a wrapper over tokio tcpstream. I'm not sure of the reason why asyncread isn't available. I'd like to learn more about websockets and try this out but I'll be busy this month. Maybe you can fork this out and try without |
@tekjar - Yeah, I'm going to try some different libraries and see if there's a more appropriate interface available, but if not, I'll try to get a proof of concept together by hacking all your code apart. |
Is there any plan for supporting MQTT over websockets in the future?
The text was updated successfully, but these errors were encountered: