Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support doctrine/common 3 #2130

Closed
jaikdean opened this issue May 29, 2020 · 6 comments
Closed

Support doctrine/common 3 #2130

jaikdean opened this issue May 29, 2020 · 6 comments

Comments

@jaikdean
Copy link

The release notes for doctrine/common 3.0.0 suggest it's easy to support both 2.x and 3.0.

@peter-mghendi
Copy link

peter-mghendi commented Aug 12, 2020

Has any work been done on this? Or is there a fork in which doctrine/common 3.0 is supported?

@jaikdean
Copy link
Author

@sixpeteunder See #2150

@peter-mghendi
Copy link

Thanks @jaikdean. I left a comment on there.

@svycka
Copy link
Collaborator

svycka commented Aug 12, 2020

we have to drop php <=7.1 versions if we want doctrine/common:3.0.0 I have created #2150 for 2.4 and #2151 for 3.0 versions but both have problems with PHP versions and also doctrine/mongodb with is deprecated and possibly more problems

@AkenRoberts
Copy link
Member

Thank you for bringing this up and doing some initial recon. 👍

There are no plans to do any of this on the 2.4.x branch. master is targeting a 3.0 release and has already done some initial work here, such as updating some dependencies, bumping the minimum PHP version to 7.2, etc.

I haven't added support for doctrine/common 3.0 yet, though. I'll take care of that now. :)

@AkenRoberts
Copy link
Member

⬆️ Completed in #2150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants