Fix transliteration. #253
Merged
Fix transliteration. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `handlesUrlization` to handler interface for handlers that handle Urlization so that we don't re-urlize and remove special characters needed by that specific handler.
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| public function handlesUrlization(){ |
There was a problem hiding this comment.
the curly brace should be on its own line
| @@ -387,4 +388,5 @@ private function filterSimilarSlugs(array &$slugs, array &$config, $prefered) | |||
There was a problem hiding this comment.
No I don't think those are tabs, but didn't realize my IDE messed up the code this much and changed all the indentations. Will correct these. Sorry about that.
| @@ -21,8 +21,9 @@ | |||
| * @link http://www.gediminasm.org | |||
| * @license MIT License (http://www.opensource.org/licenses/mit-license.php) | |||
| */ | |||
| class SluggableListener extends MappedEventSubscriber | |||
| class SluggableListener extends MappedEventSubscriber | |||
There was a problem hiding this comment.
you should also remove the trailing whitespaces added here
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
handlesUrlizationto handler interface for handlers that handle Urlization so that we don't re-urlize and remove special characters needed by that specific handler.Tests are now all passing (except one that was previously getting an error already) with transliteration separated from urlization.