Closure table should respect annotations #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR related to the one I created earlier (#241) |
|
Thanks! regarding closure strategy, it quite suck in PDO and ORM compatibility with all databases. With huge datasets nested set was faster in tests regarding inserts and updates. Maybe there are things to improve in queries used to populate closures |
l3pp4rd
added a commit
that referenced
this pull request
Feb 2, 2012
…olumns Closure table should respect annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes incorrect CREATE TABLE behaviour when I specify closure table' column names in annotations.