Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-JiraIssue uses magic $ConfigFile variable #219

Closed
KevinMarquette opened this issue Mar 8, 2018 · 3 comments
Closed

New-JiraIssue uses magic $ConfigFile variable #219

KevinMarquette opened this issue Mar 8, 2018 · 3 comments

Comments

@KevinMarquette
Copy link

$server = Get-JiraConfigServer -ConfigFile $ConfigFile -ErrorAction Stop

As I was debugging another issue and $ConfigFile was $null in my debugging session. I don't know if that was just an artifact of VSCode, but this variable looks out of place. It is not defined in this function but is being used within it.

If I had to guess, $ConfigFile was a parameter but was removed. I think you handle the null value down the stack, so this is just more of a code cleanup thing.

@KevinMarquette KevinMarquette changed the title New-JiraIssue uses magic variable New-JiraIssue uses magic $ConfigFile variable Mar 8, 2018
@lipkau
Copy link
Member

lipkau commented Mar 8, 2018

Hey.

Yes; it was a parameter.
It has been removed a long time ago...
This was already "fixed" in pr #215 and will be merged for the next minor release

@KevinMarquette
Copy link
Author

Thank you. Sorry, I should have checked the other branches.

@lipkau
Copy link
Member

lipkau commented Mar 8, 2018

No sweat.
But I am glad to hear you are using this module :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants