Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default host should be: 0.0.0.0 #77

Closed
ricardojlrufino opened this issue Oct 12, 2014 · 5 comments
Closed

Default host should be: 0.0.0.0 #77

ricardojlrufino opened this issue Oct 12, 2014 · 5 comments

Comments

@ricardojlrufino
Copy link
Contributor

I think the default host should be: 0.0.0.0 and not localhost, so avoid having to keep changing when you put the server in production or in the local access network

@jfarcand
Copy link
Member

Pull request welcomed :-)

@stuart-warren
Copy link

I realise I'm late to this issue but I have to disagree with this new default.
Surely you should have a secure default, only allow access to others by intentionally configuring it.
https://www.owasp.org/index.php/Secure_Coding_Principles#Establish_secure_defaults

You are suddenly allowing access, to a likely insecure webapp in development, to anyone on the local network...

@jfarcand
Copy link
Member

@stuart-warren So you recommend letting localhost or a better value?

@stuart-warren
Copy link

Yes, localhost to me was a much saner default for the framework.
It's not hard for a developer to configure their app to 0.0.0.0 (or something else) when they are ready to change it, like you do here: https://github.com/Atmosphere/atmosphere-samples/blob/master/nettosphere-samples/chat/src/main/java/org/nettosphere/samples/chat/NettosphereChat.java#L43

@ricardojlrufino
Copy link
Contributor Author

Hardly will startar a web server to run only as localhost, usually use to allow access to people within the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants