Feature/header and keyboard accessibility #19
Conversation
|
This looks wrong, you probably need to send the PR against the develop branch. |
|
You are correct sir!
It should be going to the correct branch now.
Sorry about that.
… On Sep 6, 2018, at 8:32 PM, Stéphane Peter ***@***.***> wrote:
This looks wrong, you probably need to send the PR against the develop branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAttVYbTqyTJMMl5qZw9A661hoxGMAN9ks5uYb6kgaJpZM4Wd-JK>.
|
| @@ -33,4 +33,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: ee630cf59de150e49c4fb03329e288268269f85e | |||
|
|
|||
| COCOAPODS: 1.5.3 | |||
There was a problem hiding this comment.
Update your CocoaPods install :)
| @@ -6,17 +6,17 @@ | |||
| <string>development</string> | |||
| <key>com.apple.developer.icloud-container-identifiers</key> | |||
| <array> | |||
| <string>iCloud.com.audiokitpro.AudioKitSynthOne</string> | |||
| <string>iCloud.com.audiokitpro.AudioKitSynthOne.Synth</string> | |||
| <string>iCloud.com.audiokitpro.AudioKitSynthOne.staque</string> | |||
There was a problem hiding this comment.
Please exclude this file from the PR since it's just for your own benefit.
There was a problem hiding this comment.
Can I just delete the file from the PR or do I have to start a new one?
There was a problem hiding this comment.
I think you might be able to remove it from the PR in GitHub though I have never tried that myself.
| @@ -1423,12 +1423,12 @@ | |||
| TargetAttributes = { | |||
| 941645C920B3597300D62851 = { | |||
| CreatedOnToolsVersion = 9.3.1; | |||
| DevelopmentTeam = 9W69ZP8S5F; | |||
| DevelopmentTeam = 69WU6LWMSQ; | |||
There was a problem hiding this comment.
Also exclude changes to this project file from the PR since it's just your internal configuration.
There was a problem hiding this comment.
Same as Above
| @@ -20,7 +20,7 @@ | |||
| <key>CFBundleDevelopmentRegion</key> | |||
| <string>en</string> | |||
| <key>CFBundleDisplayName</key> | |||
| <string>Synth One</string> | |||
| <string>Synth One Develop</string> | |||
There was a problem hiding this comment.
Also looks unnecessary to be merged
|
|
||
| private func setKeyboardModeSegment() { | ||
| keyboardModeSegment.subviews[0].accessibilityLabel = "White" | ||
| keyboardModeSegment.subviews[1].accessibilityLabel = "Black" |
There was a problem hiding this comment.
I would suggest using NSLocalizedString on all the localizable strings here.
There was a problem hiding this comment.
OH Good Catch I totally Forgot about those.
|
Actually how do I kill a PR... I just tried to remove a a file from it and bad things... |
|
Just close this PR with the button down here, or I can do it for you. |
|
Got it.
… On Sep 6, 2018, at 8:51 PM, Stéphane Peter ***@***.***> wrote:
Just close this PR with the button down here, or I can do it for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#19 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAttVcw1uW9Pa8ukbO1e5zQlpjYzFKdbks5uYcMRgaJpZM4Wd-JK>.
|
|
But yeah looks like you deleted the entire project file instead of just the part of the commit |
|
Yeah... that is why I wanted to kill it... |
|
I swear someone cast a Git Curse on me once. |
A first take on adding accessibility to just the Header and Keyboard. Not complete functionality for the Header and Keyboard them but I would say about 95%. Just something people can get to know things with. IE you can select a Preset, and play some notes.
I had to clarify some of the descriptions of controls in the Storyboard for future reference, so I hope that isn't a problem. There are also a couple custom controls you guys have created, I have to figure out a way to interact with.
This post can provide a guide how to set up VoiceOver.