Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Hide application shortcut on macOS not working #588

Closed
diegolamanno opened this issue Sep 24, 2021 · 4 comments
Closed

Hide application shortcut on macOS not working #588

diegolamanno opened this issue Sep 24, 2021 · 4 comments

Comments

@diegolamanno
Copy link

Summary

Currently, when trying to use the command in macOS to hide the application doesn't work.

How to replicate

  • On macOS press cmd+h

Expected result

  • Applications hides from the screen. This is different from cmd+m (minimized)

Tested on

  • macOS Big Sur (11.5.2)
  • Audius Version 0.24.30
@diegolamanno
Copy link
Author

diegolamanno commented Sep 24, 2021

I was trying to fix it myself but I am not familiar with the app. I am NOT an expert on electron but I believe it should be something simple with sendActionToFirstResponder. If someone can provide some guidance I can try to put a PR ☺️

@diegolamanno diegolamanno changed the title Hide application on MacOs command not working Hide application on macOs command not working Sep 24, 2021
@diegolamanno diegolamanno changed the title Hide application on macOs command not working Hide application shortcut on macOs not working Sep 24, 2021
@diegolamanno diegolamanno changed the title Hide application shortcut on macOs not working Hide application shortcut on macOS not working Sep 24, 2021
@raymondjacobson
Copy link
Member

Hi @diegolamanno thank you for posting this!
https://github.com/AudiusProject/audius-client/blob/master/src/electron.js#L282

All you should have to do is add an entry here. Looking forward to the PR :D

https://www.electronjs.org/docs/api/menu-item

@diegolamanno
Copy link
Author

Hi @diegolamanno thank you for posting this! https://github.com/AudiusProject/audius-client/blob/master/src/electron.js#L282

All you should have to do is add an entry here. Looking forward to the PR :D

https://www.electronjs.org/docs/api/menu-item

Amazing. Thanks for the info. I will give it a shot this weekend 👍

@sliptype
Copy link
Contributor

Closed, repo is deprecated. We can continue discussion here: AudiusProject/audius-protocol#5963

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants