Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat dots are not yet annotated #24

Closed
hbitteur opened this issue Sep 25, 2017 · 9 comments
Closed

Repeat dots are not yet annotated #24

hbitteur opened this issue Sep 25, 2017 · 9 comments
Assignees

Comments

@hbitteur
Copy link
Contributor

We need examples for all the various meanings of dots.

@hbitteur hbitteur changed the title [MuseScore] Repeat dots are not yet annotated Repeat dots are not yet annotated Sep 25, 2017
@nasehim7
Copy link

nasehim7 commented May 19, 2018

screen shot 2018-05-19 at 2 58 11 pm

Is this the kind of output we want after resolving this issue? :)

@hbitteur
Copy link
Contributor Author

@nasehim7 Perhaps I don't really understand your question

My position is that reference data should cover as much configurations as possible.
This include the repeat signs.
In this example, there are 2 repeat signs, one left and one right.
For each of them, try to provide the outer compound (such as left repeat sign) and its inner members (thick barline, thin barline, top repeat dot, bottom repeat dot).
Sorry, I'm writing this away from my computer, I don't have the exact symbol names at hand.

@nasehim7
Copy link

@hbitteur No problem, I got it. We want a nested approach in this one too. Working on it, currently, I'm done with getting the outer element which can be seen in the above control image. Will get back soon. :)

@nasehim7
Copy link

I did the nesting part. For Reference, Below are the control images:
screen shot 2018-05-20 at 1 59 19 am
screen shot 2018-05-20 at 1 59 31 am
Hope it is in sync with what we want for the OMR. @hbitteur @lasconic

@hbitteur
Copy link
Contributor Author

This looks OK, thanks

@nasehim7
Copy link

@hbitteur what exactly are the names of these thick and thin barlines? :)

@lasconic
Copy link
Collaborator

You can use the SMuFL names : http://www.smufl.org/version/latest/range/barlines/

@nasehim7
Copy link

nasehim7 commented May 21, 2018

@hbitteur @lasconic I think now the implementation is more refined than the previous one. Below are the control images:
screen shot 2018-05-22 at 12 33 41 am

screen shot 2018-05-22 at 12 06 40 am

I have added the commit to the existing PR. Hope it suits well. :)

@nasehim7
Copy link

@lasconic Should we close this too? It will be good in the next dataset. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants