Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked estimate gas calls #2144

Closed
bthaile opened this issue May 13, 2019 · 4 comments
Closed

Chunked estimate gas calls #2144

bthaile opened this issue May 13, 2019 · 4 comments
Assignees
Milestone

Comments

@bthaile
Copy link
Contributor

bthaile commented May 13, 2019

There are contract methods that take an array of contract address. The contract calls can't take unlimited number of contract addresses. They need to be chunked.

There is a limit to how many contracts can be passed into these loop functions.
a) redeemStake - worked
b) cancelOrders.cancelOrders (pass in orderIds) is there a limit (market trading page and portfolio)
c) claimMarketsProceeds (pass in markets) is there a limit

@pgebheim
Copy link
Member

@bthaile -- Again this will be needed for Trading to be complete, so gonna put this into that deliverable

@bthaile bthaile assigned bthaile and unassigned justinbarry Jun 30, 2019
@pgebheim
Copy link
Member

pgebheim commented Nov 5, 2019

Cleaning up modals epic

@joeykrug
Copy link
Contributor

joeykrug commented Jan 9, 2020

Need to do for a and c

@Chwy5
Copy link

Chwy5 commented Mar 31, 2020

transaction fees displayed for bulk match the amount in Transaction payment in the console

Closing

@Chwy5 Chwy5 closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants