Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Gherkin3 Parser... #17

Closed
marktaling opened this issue Nov 10, 2015 · 2 comments
Closed

Integrate Gherkin3 Parser... #17

marktaling opened this issue Nov 10, 2015 · 2 comments

Comments

@marktaling
Copy link
Member

The current Gherkin parser requires a lot of assemblies making the commandline tooling quite bulky.
I think we need to take a look at this .Net based parser

https://github.com/cucumber/gherkin3/tree/master/dotnet

@jmezach
Copy link
Member

jmezach commented Dec 2, 2016

I've started work on this. From what I can tell so far it doesn't seem that big of a change and it would remove dependency on SpecFlow altogether. That should make #40 easier to do as well.

@jmezach
Copy link
Member

jmezach commented Dec 6, 2016

I've finished the basics of moving over to the Gherkin3 parser, but I noticed that if a feature file has a #language comment at the top with a two part notation (ie. en-US or nl-NL) it throws an exception. Seems like only single part notation (ie. en or nl) is supported by the Gherkin parser.

Figuring that SpecFlow works just fine with the two part notation I had a look at how they implemented this. Looks like they try the two part first, and if that fails the strip the second part and try again: https://github.com/techtalk/SpecFlow/blob/master/TechTalk.SpecFlow.Parser/SpecFlowGherkinParser.cs#L15-L39

We could implement it the same way but we'll also have to figure out what to do with the --language option that the command line currently supports. Perhaps we should implement a GherkinDialectProvider that uses the command line option if supplied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants