Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of network exceptions #3

Closed
Brycey92 opened this issue Sep 4, 2019 · 4 comments
Closed

Better handling of network exceptions #3

Brycey92 opened this issue Sep 4, 2019 · 4 comments
Assignees

Comments

@Brycey92
Copy link

Brycey92 commented Sep 4, 2019

Issue Description:

Every so often, my console is spammed with timeout errors where Aura couldn't contact Ore or couldn't load a plugin's page on Ore. See #2 for the beginning of the discussion on this.

What happens:

When printing the exception's message, Aura is also printing its stack trace, which in this case (and probably most network exceptions) is unnecessary.

What you expected to happen:

The stack traces could be printed to debug output, and only the actual message like "Socket timed out" could be printed as a warning. Timeouts could also stand to get some proper handling, according to @BrainStone.


Affected Versions :

  • Minecraft: 1.12.2
  • AuraUpdateChecker: 1.1.2.167
@BrainStone
Copy link
Member

Mind to give me some logs how it looks currently? I’m not sure how to reproduce those network errors.

@BrainStone
Copy link
Member

@BrainStone BrainStone self-assigned this Sep 7, 2019
@Brycey92
Copy link
Author

Thanks! Sorry I didn't get those logs to you. I became busy with other things and forgot you had asked for them. I'll give it a test eventually when I have more free time.

@BrainStone
Copy link
Member

Cheers on the fast responses and feedback. I'll be happy to implement more feature requests and fix bug reports by you ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants