Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inspector items same size, fixes #115 #117

Closed
wants to merge 1 commit into from
Closed

Make inspector items same size, fixes #115 #117

wants to merge 1 commit into from

Conversation

0xWDG
Copy link
Member

@0xWDG 0xWDG commented Aug 20, 2022 •
edited

Make inspector items same size

Related Issue

#115

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

image

@0xWDG 0xWDG added enhancement New feature or request bugfix Fix for a bug user interface Inspector Inspector (right sidebar) related labels Aug 20, 2022
@0xWDG 0xWDG self-assigned this Aug 20, 2022
@0xWDG 0xWDG linked an issue Aug 20, 2022 that may be closed by this pull request
[Inspector] different text sizes. #115
Closed
@nanashili
Copy link
Member

Nope to big now

@0xWDG
Copy link
Member Author

0xWDG commented Aug 20, 2022

what size should become then?

@0xWDG 0xWDG closed this Aug 20, 2022
@nanashili
Copy link
Member

what size should become then?

It should be 11, the menu sizes need to change

@nanashili
Copy link
Member

the sizes it was, was correct the menu needs a custom view

@0xWDG
Copy link
Member Author

0xWDG commented Aug 20, 2022

The dropdown ignores sizes. (Less then 12)
It either should be written in UIKit or we must go with 12.

@nanashili
Copy link
Member

The dropdown ignores sizes. (Less then 12)
It either should be written in UIKit or we must go with 12.

The drop down is not a problem, it's more the main view of it

@0xWDG 0xWDG added this to the Version 1.0 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanashili nanashili Awaiting requested review from nanashili

@KaiTheRedNinja KaiTheRedNinja Awaiting requested review from KaiTheRedNinja

Assignees

@0xWDG 0xWDG

Labels
bugfix Fix for a bug enhancement New feature or request Inspector Inspector (right sidebar) related
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging this pull request may close these issues.

[Inspector] different text sizes.
2 participants
@0xWDG @nanashili