Tab reordering #192
Tab reordering #192
Conversation
|
Code Climate has analyzed commit 0974f6c and detected 0 issues on this pull request. View more on Code Climate. |
Conflicts: AuroraEditor/Base/Documents/Model/WorkspaceDocument/WorkspaceDocument+Tabs.swift
|
UI Issues with overlapping: |
|
Also the project navigator keeps collapsing Screen.Recording.2022-09-12.at.12.04.13.mov |
|
It also highlights the opened file when dragging a tab |
It did this even before the changes, if you dragged in the tab bar area it would select the text. I think this is a STTextView issue. |
Doubt it, because CE uses the same text view as us |
| @@ -58,9 +58,8 @@ public extension FileSystemClient { | |||
| source.resume() | |||
| self.watcher = source | |||
|
|
|||
| // reindex the current item, because the files in the item may have changed | |||
| // TODO: reindex the current item, because the files in the item may have changed | |||
| // since the initial load on startup. | |||
There was a problem hiding this comment.
did you remove fileSystemClient?.reloadFromWatcher(sourceFileItem: self) intentionally?
There was a problem hiding this comment.
It caused folders to collapse so I think he removed it for that reason
We use it in an completely different way, so it can be different. still no problem. @KaiTheRedNinja Create a issue for the highlighting, and mention it in this PR, then we can merge it. its not breaking, only annoying. |
|
Once the tests finish I'll merge this. I've already reported the weird bug with text selection. |
Description
Credit to Lingxi Li for most of the tab reordering code.
However, this PR has a few bugs.
@wdg also may need to do some modifications to WelcomeView, as currently tabContents only allows for a single tab's view to be loaded at a time, meaning that every time tabs are switched, the content in the old tab is erased. I'll make a bug report for that later.
Related Issue
Checklist
Screenshots