Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some constraints to avoid inconsistent sizing #345

Merged
merged 1 commit into from Dec 28, 2022

Conversation

Maartz
Copy link
Member

@Maartz Maartz commented Dec 28, 2022

Description

I've updated the frame property on both List and settingContentView to give minimum, maximum and ideal width for both of them.

Related issue

#344

Screenshots

image

@Maartz Maartz requested a review from a team as a code owner December 28, 2022 08:14
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2022

CLA assistant check
All committers have signed the CLA.

@0xWDG 0xWDG enabled auto-merge December 28, 2022 08:36
@0xWDG 0xWDG added UI Related to User Interface bugfix Fix for a bug labels Dec 28, 2022
@0xWDG 0xWDG added this to the Version 1.0 milestone Dec 28, 2022
Copy link
Member

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@0xWDG 0xWDG merged commit 7d346c3 into AuroraEditor:main Dec 28, 2022
@0xWDG 0xWDG mentioned this pull request Dec 28, 2022
@0xWDG
Copy link
Member

0xWDG commented Dec 28, 2022

@all-contributors please add @Maartz for bugs

@allcontributors
Copy link
Contributor

@0xWDG

I've put up a pull request to add @Maartz! 🎉

0xWDG added a commit that referenced this pull request Dec 28, 2022
Adds @Maartz as a contributor for bug.

This was requested by 0xWDG [in this
comment](#345 (comment))

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for a bug UI Related to User Interface
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants