Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cheat functionality #1116

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Fixed cheat functionality #1116

merged 2 commits into from
Aug 7, 2018

Conversation

tstambaugh92
Copy link
Contributor

The BXXXXXXX code for Gateshark was made so you could read pointers with your cheat codes, as some games store certain values in randomly assigned memory.

The original submission by TuxSH had the BXXXXXXX code do the same thing as the D300000 code. That is, to simply load the offset register with some value.

Hope this fix helps people get their codes working. Mine worked beautifully after the change!

Fixed Functionality o BXXXXXXX codes
Fixed indents
@JourneyOver
Copy link

Hope this gets merged in.. Now I dunno how many false positives I have had for both sharkive and my DB on codes that I have removed for being "broken" when in reality they might not of been.

@tstambaugh92 tstambaugh92 changed the title Fixed cheat functionaility Fixed cheat functionality Aug 7, 2018
@fincs fincs merged commit bc06b17 into LumaTeam:master Aug 7, 2018
@tstambaugh92
Copy link
Contributor Author

Another "bug" in the software for this is that cheats that don't require a button press only get used once. But since button presses still turn on cheats, I have to assume Luma is still running the cheat engine in the background the entire time correct?

I'd like to take a crack and making codes work constantly this weekend(work gets in the way between now and Friday). However, I don't want to do so if for some reason this design choice were intentional and the work would get rejected. Are constant codes that would allows for infinite items and invincibility as the original gateshark provides something you'd take if I got it working?

@tstambaugh92
Copy link
Contributor Author

Line 1154 looks like the code is only trying to constantly run cheats that are button activated. I feel like a hot fix modification to this might actually get it working. Since it's literally one line of code I'll try it tonight and post results. If the change it rejected the change is rejected I guess.

Sahlo97 pushed a commit to Sahlo97/Luma3DS that referenced this pull request Dec 9, 2021
Fixed functionality of BXXXXXXX codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants