Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cheat functionality #1117

Merged
merged 3 commits into from Aug 9, 2018

Conversation

Projects
None yet
5 participants
@tstambaugh92
Copy link
Contributor

commented Aug 8, 2018

Gateshark codes without key presses are intended to run forever. The way the code was previously written, only key combo cheats were run more than once, which breaks all sorts of infinite cheats like health, lives, magic, etc.

I tested these code changes and it fixed gateshark functionality. No decrease in performance from running more cheats was observed in the several games I tried. Cheats that still require a button press still work as well from my previous pull request.

The logic for renaming the function ApplyKeyCheats is simply that it now applies all cheats, as thats the point of this change.

@JourneyOver

This comment has been minimized.

Copy link

commented Aug 8, 2018

Hoping this gets merged in as usual, fixes for the cheat functionality are always good to have.

@JourneyOver JourneyOver referenced this pull request Aug 8, 2018

Merged

Majoras Mask 3D (USA) #46

0 of 3 tasks complete
@Shadow322

This comment has been minimized.

Copy link

commented Aug 9, 2018

@fincs please push this git pull

@tstambaugh92

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

I've had my kids testing it all day but I'm sure they want to make sure I didn't dick something up before accepting. Better safe than sorry.

@fincs fincs merged commit 2219b19 into AuroraWright:master Aug 9, 2018

@tstambaugh92

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

Thanks for the merge fincs. Glad I could help out.

@fincs

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2018

( ͡° ͜ʖ ͡~)

@james-d-elliott

This comment has been minimized.

Copy link

commented Aug 13, 2018

Thank your quality assurance and UX departments, they also did a great job @tstambaugh92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.