Fixed cheat functionality #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hoping this gets merged in as usual, fixes for the cheat functionality are always good to have. |
3 tasks
|
@fincs please push this git pull |
|
I've had my kids testing it all day but I'm sure they want to make sure I didn't dick something up before accepting. Better safe than sorry. |
|
Thanks for the merge fincs. Glad I could help out. |
|
( ͡° ͜ʖ ͡~) |
|
Thank your quality assurance and UX departments, they also did a great job @tstambaugh92 |
Sahlo97
pushed a commit
to Sahlo97/Luma3DS
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gateshark codes without key presses are intended to run forever. The way the code was previously written, only key combo cheats were run more than once, which breaks all sorts of infinite cheats like health, lives, magic, etc.
I tested these code changes and it fixed gateshark functionality. No decrease in performance from running more cheats was observed in the several games I tried. Cheats that still require a button press still work as well from my previous pull request.
The logic for renaming the function ApplyKeyCheats is simply that it now applies all cheats, as thats the point of this change.