Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select by ID instead of path #48

Closed
wants to merge 2 commits into from
Closed

Select by ID instead of path #48

wants to merge 2 commits into from

Conversation

rdela
Copy link
Contributor

@rdela rdela commented Feb 28, 2018

@rdela
Copy link
Contributor Author

rdela commented Feb 28, 2018

Hmmm deploy preview looks funky, local develop/build were fine, ideas? See anything suspect in the diff?

@rdela
Copy link
Contributor Author

rdela commented Feb 28, 2018

Or maybe is no big deal as https://gatsby-netlify-cms.netlify.com/ looks the same?

@AustinGreen
Copy link
Contributor

AustinGreen commented Feb 28, 2018

Seems like the CSS didn't get picked up. Yesterday, the build passed for the first time in a while and for some reason the CSS is broken. I think this PR is good to go regardless, but we should also get a hotfix out soon for the CSS.

EDIT: a redeploy with a cleared cache fixed it, so ignore the CSS issue.

@erquhart
Copy link
Contributor

Does this mean you don't need the path property in frontmatter? It'd be awesome if the output path were derived from the file path.

@rdela
Copy link
Contributor Author

rdela commented Feb 28, 2018

Thanks. @AustinGreen Have you tried the “Retry deploy” with “Clear build cache” checked? Maybe is a caching thing?

@rdela
Copy link
Contributor Author

rdela commented Feb 28, 2018

@erquhart maybe not? can you expound on

if the output path were derived from the file path

part?

@KyleAMathews
Copy link
Contributor

Check out gatsby-starter-blog, it creates paths from the filename. There's a helper function for doing this

@AustinGreen
Copy link
Contributor

I appear to have this working. Will commit to this PR, I had to change around the file directories to get the paths correct

@AustinGreen
Copy link
Contributor

AustinGreen commented Feb 28, 2018

#50 includes @rdela commits from this PR and my commit to derive paths. Thank you all for the team effort. Closing this PR in favor of #50.

@rdela rdela deleted the select-by-id branch February 28, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants