Mainnet audit base branch #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove entry struct - remove all name-related require lines - update tests accordingly
…ng only .gitignored files on npm run clean and npm run clean:build
- Add missing dependencies - Make rewards capable to run in isolation - ganache-cli.sh still needs a path change on that case - Remove unused dependencies (react-motion) - Remove @tps/test-helpers dep
- Stop using @tps/test-helpers, use @aragon instead, or local if needed - Consolidate inline helper functions - Refactor artifacts requirements - Refactor before hook and modernize to follow modern trends - Remove unused variables and functions - Fix typos - Lint file
- Sort to prevent reentrancy - Use inherited TimeHelpers functions - Lint spacing - Extract transfer reward logic to new private function
- Sort to prevent reentrancy - Add additional comments - Fix typos - Use MiniMeToken instance instead of address of referenceToken - Make guards cleaner, merge `if` condition into the guard
* dev: (39 commits) Projects: revert to old aragonUI version Projects: mv AppTitleButton Dot Voting/date-fns: use v2 formatting strings Upgrade date fns (#1188) upgrade Rewards ADS UI (#1187) Aragon DS upgrade: addressbook (#1156) Revert Rewards & Projects to previous aragonUI Dot Voting: fix issues found during QA Dot Voting/CastVote: fix prop type Revert "[DEV] rm pre-commit lint" Dot Voting: mv totalSupport calc to VotingResults Dot Voting/VoteDetails: mv Participation Dot Voting/CastVote: rm tokenData; keep userBalance Dot Voting: define tokenContract in CastVote Dot Voting: mv CastVote to own file Dot Voting/VoteDetails: mv VoteEnact & VotingResults Add a minimal EMPTY_ROLE to Discussions - This is needed to be considered an actual Aragon app by the Kernel - Reference: https://hack.aragon.org/docs/cli-dao-commands#dao-install Remove partial ACL guards on discussions: Discussions: fix typos in README examples Dot voting demo fixes (#1176) ...
ottodevs
added
app: address book
app: allocations
app: dot voting
app: projects
app: rewards
contracts
|
Closing since the audit is wrapping up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will contain every change from the audits to have a final review of the changes for each app combined to be ready for mainnet.
Depends on mainnet audit changes from: