Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change request for "LocatorAssertions.setDefaultTimeout" #1

Closed
N1ro opened this issue Mar 10, 2022 · 1 comment
Closed

Change request for "LocatorAssertions.setDefaultTimeout" #1

N1ro opened this issue Mar 10, 2022 · 1 comment

Comments

@N1ro
Copy link

N1ro commented Mar 10, 2022

Hello everyone,

This is a change request, not a issue, raising here as I'm not sure how to raise a change request with playwright.
I'd like to request a change for LocatorAssertions.setDefaultTimeout()

Why?
Currently, assertions are performed like below with setTimeout, we'd like to know if its possilbe to add LocatorAssertions.setDefaultTimeout() so we can setup locationAssertions timeout globallly, rather individually.

assertThat(page.locator( LoginPage.ERROR_MESSAGE_CONTAINER )) .hasText( expectedMessage, new LocatorAssertions.HasTextOptions().setTimeout( 30000 ) );

        Please let us know if you need more info.

Thanks
Niro

@N1ro N1ro closed this as completed Mar 11, 2022
@N1ro
Copy link
Author

N1ro commented Mar 11, 2022

raised it by mistakently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant