fix(tools): create s3url pathStyle not used #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
funky-eyes
changed the title
|
Good catch, and thanks for your contribution. After we merge this PR, you could use |
Ok, I'll try to compile it and verify it |
|
I've verified it through. |
superhx
pushed a commit
that referenced
this pull request
Mar 14, 2024
* bugfix: create s3url pathStyle not used * bugfix: create s3url pathStyle not used
ShadowySpirits
pushed a commit
that referenced
this pull request
Mar 14, 2024
* bugfix: create s3url pathStyle not used * bugfix: create s3url pathStyle not used (cherry picked from commit 7e1280f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
fixes #883
Committer Checklist (excluded from commit message)