Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all partitions have been closed in broker shutdown #126

Closed
mooc9988 opened this issue Sep 13, 2023 · 1 comment · Fixed by #135
Closed

Make sure all partitions have been closed in broker shutdown #126

mooc9988 opened this issue Sep 13, 2023 · 1 comment · Fixed by #135

Comments

@mooc9988
Copy link
Contributor

When a broker is shutting down, a partition may be closed due to

  • leader change
  • or log manager's closure.

For the former case, the broker need to wait for partition's closure.

@mooc9988
Copy link
Contributor Author

When a broker is shutting down, all partitions will be reassigned to other active brokers. It will lead to partitions' closure in the shutting down broker. Partition's closure will then remove the log from LogManager. For now, partition's closure is done in partitionOpenCloseExecutors. Therefore, broker have to wait for partitionOpenCloseExecutors shutting down.

If the broker is the last broker, partitions in this broker will turn into followers. They will all be closed in LogManager's shutting down.

@mooc9988 mooc9988 linked a pull request Sep 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant