Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertConfigurationIsValid collect all errors rather than throw first one #660

Closed
hazzik opened this issue Jan 6, 2015 · 4 comments
Closed
Milestone

Comments

@hazzik
Copy link
Contributor

hazzik commented Jan 6, 2015

It would be useful to see all mapping validation errors at one go http://martinfowler.com/articles/replaceThrowWithNotification.html

@hazzik
Copy link
Contributor Author

hazzik commented Jan 6, 2015

In DryRun

@jbogard
Copy link
Member

jbogard commented Jan 6, 2015

So currently I do a two step operation - first find unmapped members, then find unmapped types. This is to do both in one go?

@hazzik
Copy link
Contributor Author

hazzik commented Jan 7, 2015

Not in one go, but in one exception. Currently if you have unmapped types, AM will throw one exception for each unmapped type usage.

Consider following situation

class A {} 
class B {} // A => B is NOT mapped
class Source 
{
    public A P1 {get; set;}
    public A P2 {get; set;}
    public A P3 {get; set;}
}
class Dest
{
    public B P1 {get; set;}
    public B P2 {get; set;}
    public B P3 {get; set;}
}

So the sequence of events would be like this:

  1. AM throws that Source.P1 => Dest.P1 using unmapped A => B
  2. Fix by doing something about this, but do not map A=>B & Recompile & Run
  3. Repeat for next unmapped class

@jbogard jbogard added this to the 4.0.0 milestone Apr 24, 2015
@lock
Copy link

lock bot commented May 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants