Fix for element connection in arnold node graph #1031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a warning in the render delegate code for connecting array elements
This doesn't amount to a bug in the render delegate, but is in fact only searching for the last :, not the last :i since we pass a char not a string. If we has used a string it would pick the last of : OR i which is not what we want either.
We can fix by using rfind("i0") and updating the indices.
Note we only get different behaviour for strings such as input[3].i which we would represent as input:i0:i, but we would never have such connections, only input[3].x or similar (i.e. components x,yz,r,g,b,a).
But this fix will make the code tighter and remove the compile warning.
Fixes #1031