Extend the WriteUsdStageCache API #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpichard
reviewed
Jan 15, 2024
plugins/procedural/main.cpp
Outdated
| if (!AiParamValueMapGetStr(params, str::mtl_scope, &mtlScope)) | ||
| mtlScope = AtString("/mtl"); | ||
|
|
||
| writer.SetMtlScope(std::string(mtlScope.c_str())); |
There was a problem hiding this comment.
I am not sure; but shouldn't the SetMtlScope be inside the condition ?
There was a problem hiding this comment.
not really. It's written as in the other code path, in a way that if it's not set, it defaults to "/mtl". But it's confusing indeed so in the last commit I'm just setting "/mtl" as the default in the writer class, and the procedural code can then apply the same logic as for the other attributes
cpichard
reviewed
Jan 15, 2024
cpichard
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WriteUsdStageCache API isn't exercised yet, it's meant to be used by MtoA and MAXtoA to avoid linking against USD.
It just had a "frame" argument hardcoded, but we actually want to extend it to have roughly the same set of optional parameters as
scene_write. For that we use now aAtParamValueMapso that any argument can be added without changing the API signature. Since this isn't exercised yet, it might not be useful to add a note in the changelog