Inject siteId #13
Merged
Inject siteId #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroalonso
requested changes
Aug 12, 2021
There was a problem hiding this comment.
@momo-ozawa works as described!
I'd just change siteId to be optional, given it's not a mandatory field.
Source/MobilePayKit.swift
Outdated
|
|
||
| public init(oAuthToken: String, bundleId: String?) { | ||
| public init(oAuthToken: String, bundleId: String?, siteId: String) { |
There was a problem hiding this comment.
siteId is optional, I think we can make it optional and assign a default nil value, wdyt?
There was a problem hiding this comment.
There's a build error after this change, you need to update the remaining places too. :D
There was a problem hiding this comment.
Oof! Fixed... updated site_id to Int? as well, per D65254-code
The site_id type is integer
leandroalonso
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR injects the site id into MobilePayKit.
Notes
Apply patch to test the new createOrders endpoint (D65254-code)
For sandbox info, follow instructions in these posts:
How to test
Running tests
Running the app
ProductListViewModelMobilePay-Apple/Example/iOS/MobilePayKit-iOS/ProductListViewModel.swift
Lines 31 to 35 in 03400b3