Add initial networking layer #5
Conversation
|
@momo-ozawa These tests are failing:
|
There was a problem hiding this comment.
Hiya! Overall this works really well! I left a couple comments below.
In addition the tests that are failing, I found the macOS example doesn't build because navigationBarItems is for iOS only.
Also, I'm unsure we need to use Alamofire since the requests themselves are pretty simple, and we should be able to use URLSession's instead. Unless there was a specific reason you chose to use AF?
|
|
||
| iapService.createOrder( | ||
| identifier: product.productIdentifier, | ||
| price: Int(truncating: product.price), |
There was a problem hiding this comment.
The value of the price should be in cents, if the price is 5.99 then it should be converted to: 599.
In theory this should work unless there's a better way:
Int(price.floatValue * 100)
There was a problem hiding this comment.
Fixed. cd1fb1f
Thank you for updating the API docs as well! 🙇♀️
|
|
||
| guard let appStoreReceiptURL = Bundle.main.appStoreReceiptURL, | ||
| FileManager.default.fileExists(atPath: appStoreReceiptURL.path) else { | ||
| print("Could not find app store receipt") |
There was a problem hiding this comment.
Should we handle the returns as errors?
There was a problem hiding this comment.
Yes! I'm thinking of creating a separate PR for error handling.
I think this PR might get big if I changed the CompletionCallbacks from (T) -> Void to something like (Result<T, Error>) -> Void.
| "object": { | ||
| "pins": [ | ||
| { | ||
| "package": "Alamofire", |
There was a problem hiding this comment.
@momo-ozawa there's any special reason why we need Alamofire?
I think it would be good to keep this library without dependencies and as much light as possible. Nowadays URLSession is very powerful so I think we can go with it.
This can be refactored on a future PR though.
|
@momo-ozawa as we talked, let's ignore the failing tests for now and then we can get back to those later. |
For the purchased / restored tests to pass, we need to build a receipt stub and a mock iapService.
|
@leandroalonso @emilylaguna I'll be removing Alamofire in favor of URLSession in my next PR 🙇♀️ |
|
Closing this PR due to merge conflicts -- I will create a new PR! |
Description
Resolves wordpress-mobile/WordPress-iOS#16863
This PR adds the initial networking layer:
InAppPurchasesServiceto call the fetch product skus / create order endpointsInAppPurchasesServiceTestsInAppPurchasesAPIRouterto organize the endpointsNotes
How to test
Configuration.storekit