Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Alamofire in favor of URLSession #7

Closed
wants to merge 10 commits into from
Closed

Remove Alamofire in favor of URLSession #7

wants to merge 10 commits into from

Conversation

momo-ozawa
Copy link
Contributor

Description

This PR removes Alamofire in favor of URLSession

  • Removed Alamofire from package dependencies
  • Added a Networking protocol (URLSession conforms to this protocol, which enables us to passURLSession.shared as the default parameter for InAppPurchasesService

Notes

  • I'm skipping the InAppPurchaseServiceTests for now because the fetchProducts and createOrder methods aren't actually calling networking.load(request:) yet

How to test

  1. Run the iOS app
  2. Tap on Rocket Fuel to purchase
  3. Tap Confirm
  4. Tap OK
  5. On Xcode debugger menu, click on the Manage StoreKit Transactions menu item
  6. ✅ There should be a record of Rocket Fuel being purchased

@momo-ozawa momo-ozawa changed the title Remove Alamofire in favor or URLSession Remove Alamofire in favor of URLSession Jul 30, 2021
@momo-ozawa
Copy link
Contributor Author

Closing this PR and reopening a new PR that combines this PR with #5

@momo-ozawa momo-ozawa closed this Aug 2, 2021
@momo-ozawa momo-ozawa mentioned this pull request Aug 2, 2021
Merged
@momo-ozawa momo-ozawa deleted the task/remove-af-add-urlsession branch August 27, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilylaguna emilylaguna Awaiting requested review from emilylaguna

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@momo-ozawa