Fix handling of amp-bind attributes to ensure that “>” can appear inside attribute values #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RACK_LIMIT_ERRORs Update dev-lib to fix unit test config failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spurred on by @surma's post: My most useful RegExp trick.
The key part to getting this to work on large data sets was something new to me in regex: Possessive Quantifiers. This prevents backtracking and avoids
PREG_BACKTRACK_LIMIT_ERRORfrom happening.So now WordPress-served responses can successfully include:
Whereas previously this would fail and cause
'' != className )">to be the first text content of thebodyelement. With this PR it is no longer is it required to use>in the attribute as a workaround.There was no perceived change in performance between the old and new regex patterns.
Again, the reason for all of this regex replacing is because PHP's DOMDocument (via libxml) does not like the bracketed amp-bind attribute syntax. So we have to convert them prior to parsing and restore them after serializing.