Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass '/' as an argument to home_url(), preventing possible 404 #1161

Merged
merged 1 commit into from
May 18, 2018
Merged

Pass '/' as an argument to home_url(), preventing possible 404 #1161

merged 1 commit into from
May 18, 2018

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented May 18, 2018 •
edited

Request For Code Review

Could you please review this pull request for #1158?

As you saw, there's a support topic where the link wrapping the home logo in legacy templating lead to a 404 page.

And according to the documentation for home_url(), passing the '/' argument is the default usage.

Closes #1158

@kienstra
Pass '/' as an argument to home_url(), preventing possible 404.
cde2f34 
In response to a support topic,
where the link wrapping the home logo in
legacy templating lead to a 404 page.
According to the documentation for home_url(),
passing the '/' argument is the default usage.
@see https://wordpress.org/support/topic/need-to-add-slash-to-end-of-url/#post-10293713
@kienstra kienstra changed the title Pass '/' as an argument to home_url(), preventing possible 404. Pass '/' as an argument to home_url(), preventing possible 404 May 18, 2018
@westonruter
Copy link
Member

@kienstra maybe we should rebase the commit onto the 0.7 branch?

@westonruter westonruter merged commit 9703ddf into develop May 18, 2018
@westonruter
Copy link
Member

That is, should we cherry-pick this into the 0.7 branch?

@kienstra
Copy link
Contributor Author

kienstra commented May 18, 2018 •
edited

Hi @westonruter,
Sure, we might as well include this in 0.7 for the 0.7.1 release.

@kienstra
Copy link
Contributor Author

Sorry, it looks like I don't have permission to push to 0.7:

remote: error: GH006: Protected branch update failed for refs/heads/0.7.
remote: error: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.

@westonruter westonruter added this to the v0.7.1 milestone May 18, 2018
@westonruter westonruter deleted the home-url branch May 18, 2018 19:05
@westonruter
Copy link
Member

I cherry-picked and amended with readme change to 0.7 branch: 62483f0

@kienstra
Copy link
Contributor Author

Thanks, I just built the 0.7 branch and manually uploaded amp.zip to:
https://paired-ampconfdemo.pantheonsite.io/
https://native-ampconfdemo.pantheonsite.io/
https://legacy-ampconfdemo.pantheonsite.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kienstra @westonruter