Fetch (local) stylesheets with @import instead of removing #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
commented
May 29, 2018
| 'code' => 'illegal_css_import_rule', | ||
| 'message' => __( 'CSS @import is currently disallowed.', 'amp' ), | ||
| ); | ||
| $this->parse_import_stylesheet( $css_item ); |
There was a problem hiding this comment.
@westonruter Still WIP but started adding the support for @imported stylesheets, any thought on the approach?
There was a problem hiding this comment.
Yes, your approach is great. I went ahead and iterated on it because of the changes introduced by the refactored error validation handling.
Also guard against infinite @import recursion
…pdate/1091-fetch_import_rules
…tion Kses corruption Also ensure that CSS parsed cache varies by get_validated_url_file_path errors.
westonruter
changed the title
westonruter
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
@importstylesheets. Local stylesheets are inlined, and external stylesheets are reported as sanitizeable validation errors.Fixes #1091.