Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code quality checking via phpcs, eslint, jscs, and jshint #795

Merged
merged 7 commits into from Nov 6, 2017

Conversation

westonruter
Copy link
Member

  • Limit checking of code to the lines that are modified in scope of the pull request; this will allow for adherence to linting rules to be applied incrementally in the context of PRs without having to fix everything up front in order to get a passing build.
  • Fix i18n errors related to UnorderedPlaceholdersText and MissingArgDomain.
  • Add wp-dev-lib, which is added as submodule.
  • Re-use phpunit bootstrap from wp-dev-lib.
  • Update Travis to use container-based environment and use caching to improve performance.

Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding wp-dev-lib into the development workflow of the plugin is great! Spent some time looking into wp-dev-lib and the changes in this PR look good to me.

@amedina
Copy link
Member

amedina commented Nov 6, 2017

Ready to merge.

@westonruter westonruter merged commit 647b003 into master Nov 6, 2017
@westonruter westonruter deleted the add/dev-lib branch November 6, 2017 19:31
@westonruter westonruter added this to the v0.6 milestone Nov 7, 2017
@westonruter westonruter added this to Done in v0.6 Nov 7, 2017
@ThierryA ThierryA moved this from Done to Ready for Merging in v0.6 Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.6
Ready for Merging
Development

Successfully merging this pull request may close these issues.

None yet

2 participants