Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FailedBuild status for faster error detection #12

Open
hoverduck opened this issue Feb 13, 2018 · 1 comment
Open

Add FailedBuild status for faster error detection #12

hoverduck opened this issue Feb 13, 2018 · 1 comment

Comments

@hoverduck
Copy link

Currently the canary tests that run against dserve don't have any way to detect when an image fails to build, so they need to wait for the full 10-minute timeout to report failure back to the PR. It would be helpful to have the /status endpoint register that there was a failure, and even provide the error message (i.e Encountered error when building image vs Encountered error while git checking out, tarballing, or handing to docker) for display on the CircleCI output

@samouri
Copy link
Contributor

samouri commented May 1, 2018

This shouldn't be too bad. I don't think we currently make any changes to the fs to mark a branch as failed. My guess is that implementing this intelligently could be ~20 LOC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants