Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icons: Sharing icons #48

Closed
12 of 13 tasks
kellychoffman opened this issue Jul 17, 2015 · 10 comments
Closed
12 of 13 tasks

Add Icons: Sharing icons #48

kellychoffman opened this issue Jul 17, 2015 · 10 comments

Comments

@kellychoffman
Copy link
Member

Sharing (sharing/) uses the following social icons:

  • Facebook
  • Twitter
  • Google+
  • LinkedIn
  • Tumblr
  • Path
  • Eventbrite

And the sharing buttons (that are not listed above)
sharing buttons

  • Mail
  • Print
  • Reddit
  • Press This
  • Pinterest
  • Pocket
@davewhitley
Copy link
Contributor

I've made an illustrator file with most of these logos in Dropbox under fonts/gridicons. I've taken the raw logos and sized them to our icon grid (without affecting the vectors of the logos). I'll keep them there until we figure out what to do with logos.

@kellychoffman
Copy link
Member Author

Okay. Does this mean we aren't sure if they are going in gridicons? How would I switch the /sharing page over? We will also be needing many of these for the sharing metabox in the editor.

@davewhitley
Copy link
Contributor

I don't think they should be in the icon set, but we still need an easy way to use them on the web.

We could

  1. Make a new repo (gridicons-social). It would be a clone of this repo but with logos instead of icons. Somehow when we export the icons, gridicons and gridicons social would combine into one component file.

  2. Make a new folder in this repo just for social icons. Export would be similar to 1.

  3. Create a separate public repo that just includes the gridicon icon set. There would be no mention of the grunt/react specifics or Calypso. We could link to this public repo in our handbook. In the private repo, we could include the social logos directly in the icon set. Also, we would be free to include our WordPress.com specific things.

For the sharing buttons, I don't know how we could use our current react setup to display those on the frontend.

@davewhitley
Copy link
Contributor

Print:

screen shot 2015-08-03 at 4 30 22 pm

@jasmussen
Copy link
Member

Agree with Dave on not adding any logos (save for the "My Sites" WordPress version) to Gridicons, and that the solution is a separate set.

I would also add that Genericons are probably fine to keep using for the foreseeable future for the sharing service. We can even make a new icon font just for the sharing service. Because the sharing service will go in Jetpack, it seems logical to keep it an icon font, for maximum ease of use, and I cannot stress enough how easy it is to make an icon font using FontCustom.

@folletto
Copy link
Contributor

folletto commented Aug 4, 2015

Make a new folder in this repo just for social icons. Export would be similar to 1.

I like this idea. Separate but in the same context, so it's easily found (and doesn't split the issue board too). :)

@davewhitley
Copy link
Contributor

I like option 3

Create a separate public repo that just includes the gridicon icon set. In the private repo, we could include the social logos directly in the icon set.

because I think it also solves the problem of making this repo public. But, we would have to update 2 repos every time we add an icon.

@kellychoffman
Copy link
Member Author

A separate repo works for me.

@kellychoffman
Copy link
Member Author

Already getting our first "where's the updated google logo?" request. That request is for the sharing buttons on the front end, but we will also need it in the editor and in /sharing.

button-gplus

I found the g+ icons: https://cloudup.com/cnxcoFOfZ_g on their branding guidelines page.

@kellychoffman
Copy link
Member Author

Closing this in favor of: https://github.com/Automattic/social-logos/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants