-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icons: Sharing icons #48
Comments
I've made an illustrator file with most of these logos in Dropbox under fonts/gridicons. I've taken the raw logos and sized them to our icon grid (without affecting the vectors of the logos). I'll keep them there until we figure out what to do with logos. |
Okay. Does this mean we aren't sure if they are going in gridicons? How would I switch the /sharing page over? We will also be needing many of these for the sharing metabox in the editor. |
I don't think they should be in the icon set, but we still need an easy way to use them on the web. We could
For the sharing buttons, I don't know how we could use our current react setup to display those on the frontend. |
Agree with Dave on not adding any logos (save for the "My Sites" WordPress version) to Gridicons, and that the solution is a separate set. I would also add that Genericons are probably fine to keep using for the foreseeable future for the sharing service. We can even make a new icon font just for the sharing service. Because the sharing service will go in Jetpack, it seems logical to keep it an icon font, for maximum ease of use, and I cannot stress enough how easy it is to make an icon font using FontCustom. |
I like this idea. Separate but in the same context, so it's easily found (and doesn't split the issue board too). :) |
I like option 3
because I think it also solves the problem of making this repo public. But, we would have to update 2 repos every time we add an icon. |
A separate repo works for me. |
Already getting our first "where's the updated google logo?" request. That request is for the sharing buttons on the front end, but we will also need it in the editor and in /sharing. I found the g+ icons: https://cloudup.com/cnxcoFOfZ_g on their branding guidelines page. |
Closing this in favor of: https://github.com/Automattic/social-logos/ |
Sharing (
sharing/
) uses the following social icons:And the sharing buttons (that are not listed above)
![sharing buttons](https://cloud.githubusercontent.com/assets/5835847/8751860/f828fc88-2c7d-11e5-9692-9e8afb8b4e27.png)
The text was updated successfully, but these errors were encountered: