Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS issues in multiple editor parts #160

Closed
fernandomm opened this issue Jun 16, 2022 · 3 comments
Closed

CSS issues in multiple editor parts #160

fernandomm opened this issue Jun 16, 2022 · 3 comments

Comments

@fernandomm
Copy link

fernandomm commented Jun 16, 2022

I was running this project locally and noticed some CSS issues that aren't present in the "original" Gutenberg editor.

Some examples:

  1. When a column is focused, the border is off

Captura de Tela 2022-06-16 às 10 52 12

  1. The close icon border has problems

Captura de Tela 2022-06-16 às 10 31 59

  1. When searching for a new block, horizontal scrollbars are created when cursor is hover an item

Captura de Tela 2022-06-16 às 10 50 37

  1. The inspector CSS seems to be missing

Captura de Tela 2022-06-16 às 10 58 27

At least the 3 first issues seems to be caused by this CSS

// Stops a bit of judder when an empty editor is first clicked. Not sure why there is a difference between .com and .org
.editor-block-list__layout > .block-list-appender:first-child,
.block-editor-block-list__layout > .block-list-appender:first-child,
.block-editor-block-list__layout > div:first-child > .block-list-appender {
padding-top: 3px;
margin-bottom: 19px;
button {
margin-left: 16px;
}
}

After removing it the 3 first issues were fixed without any noticeable side effects. Is it safe to remove these custom rules? I can submit a PR if you're ok with it.

@johngodley
Copy link
Member

Sure, a PR would be great! It's likely this is old CSS that was relevant to a previous version of Gutenberg and may now be causing problems.

I was able to reproduce 1.

For 2 this is seen in core Gutenberg too. The icon shouldn't actually appear, and this was fixed in #157

I can't reproduce 3, but maybe there are some other local differences.

4 is probably worth splitting off into a separate issue.

@johngodley
Copy link
Member

This will be fixed by #165 and #164

@johngodley
Copy link
Member

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants