Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toolbar defaults #19

Closed
johngodley opened this issue Mar 15, 2021 · 3 comments · Fixed by #62
Closed

Improve toolbar defaults #19

johngodley opened this issue Mar 15, 2021 · 3 comments · Fixed by #62

Comments

@johngodley
Copy link
Member

The toolbar needs some solid defaults that work across different width screens.

Here's what things look like on a small editor:

image

The toolbar is correctly wrapping, but the style isn't quite right and it obscures the editor

@jasmussen
Copy link
Member

To an extent, I think this worth fixing directly in the core project. Right now the stacked toolbar is an overlay that covers content even there, including the scrollbar. But it should not cover content, it should push the content down.

@johngodley
Copy link
Member Author

That makes sense. I'll put together an issue over in Gutenberg.

I think there are some related padding issues specific to here, so I'll try and split those out so this issue is a bit more focussed.

@johngodley
Copy link
Member Author

Here's a screenshot of the padding issue that often occurs, with the vertical grey lines not quite reaching the top or bottom:

image

It's something to do with a height of 48px and 60px. I'll track down more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants