Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 6.4 Support #238

Closed
spencerfinnell opened this issue Oct 12, 2023 · 6 comments
Closed

WordPress 6.4 Support #238

spencerfinnell opened this issue Oct 12, 2023 · 6 comments

Comments

@spencerfinnell
Copy link

Hello @johngodley, first of all, thank you for all of your great work on this project -- it's immensely helpful.

I'm wondering about your plans for supporting multiple versions of WordPress when the lock/unlock needs to be updated for each major WordPress version?

WordPress/gutenberg#49784

Changing it to support 6.4 will break 6.3, etc.

FYI -- that change seemed all that was needed for testing the latest Gutenberg nightly (in my usage).

@johngodley
Copy link
Member

It's difficult enough supporting one version and there are no plans to support more!

@spencerfinnell
Copy link
Author

So the plan is always the latest official major release of WordPress?

@spencerfinnell
Copy link
Author

Draft PR #239 has my findings for 6.4 support.

@johngodley
Copy link
Member

Unfortunately it's not that straightforward. This project is only tested against specific versions of Gutenberg libraries, and the recommendation (if you are using it on a WP site) is to use the Gutenberg plugin that matches those versions.

The mapping between the plugin and the version of Gutenberg built into WordPress is not simple, and I can't say which version it will work with. Often the built-in version won't work as it's a few months older and doesn't provide the functions that this project relies on. Right now the version in WordPress is much newer.

@spencerfinnell
Copy link
Author

Right. I know it's a jumble.

I had been using the isolated editor with WordPress 6.3 (no Gutenberg plugin), then installed Gutenberg nightly and the changes in the PR were all I found that were needed to support it -- previously there were a lot more incompatibilities. 🤷🏻

Feel free to close both the issue and PR if they aren't relevant to the planned update process.

@spencerfinnell
Copy link
Author

Implemented via #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants