Juice not removing all <style> #470

phstc · 2023-08-02T04:01:35Z

I'm trying to remove all <style> from an HTML, but juice is keeping some out.

If I paste the HTML on the demo website it removes all <style> 🤷‍♂️

I'm using juice 9.1.0.

Sample RunKit https://runkit.com/embed/fjqdnm3ckkdv (change the output from Rendered HTML to Full Text)

const fs = require('fs');
const juice = require('juice');

const rawHtml = `
  <!DOCTYPE html>
  <html>
  <head>
    <style>
a:hover {
  color: #000 !important;
}
a:active {
  color: #000 !important;
}
a:visited {
  text-decoration: none;
  color: #00c8b4 !important;
}
@media only screen and (max-width: 600px) {
  table[class="body"] img {
    height: auto !important;
    width: auto !important;
  }
}

    </style>
  </head>
  <body>
    Test!!!
  </body>
  </html>
`;

const juiceHtml = juice(rawHtml)
console.log(juiceHtml)

/*

OUTPUT:

  <!DOCTYPE html>
  <html>
  <head>
    <style>
a:hover {
  color: #000 !important;
}
a:active {
  color: #000 !important;
}
a:visited {
  text-decoration: none;
  color: #00c8b4 !important;
}
@media only screen and (max-width: 600px) {
  table[class="body"] img {
    height: auto !important;
    width: auto !important;
  }
}
</style>
  </head>
  <body>
    Test!!!
  </body>
  </html>


*/

Any ideas on what it could be?

I did try with the same options as on the demo website, but still, it did not work. The most important option is removeStyleTags, but that's true by default.

The text was updated successfully, but these errors were encountered:

phstc · 2023-08-07T18:19:58Z

Great troubleshooting by Marco on StackOverflow https://stackoverflow.com/a/76829914/464685

Apparently, the webversion of juice uses an extremely outdated version which gives a different behaviour because a different CSS parser is used.

This seems to be a big regression compared with the demo website. The only version I could reproduce the demo website output (not keeping style tags) was version 1.0.0.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Juice not removing all <style> #470

Juice not removing all <style> #470

phstc commented Aug 2, 2023 •

edited

phstc commented Aug 7, 2023

Juice not removing all <style> #470

Juice not removing all <style> #470

Comments

phstc commented Aug 2, 2023 • edited

phstc commented Aug 7, 2023

phstc commented Aug 2, 2023 •

edited