fix RangError: Maximum call stack exceeded error

closes #714 relates to #688
Automattic · Feb 3, 2012 · 746afb2 · 746afb2
1 parent 8653c73
commit 746afb2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 33 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -393,12 +393,15 @@ Model.prototype._delta = function _delta () {
         }
       }
     } else {
-      // normalize MongooseArray or MongooseNumber
       if (type instanceof MongooseArray ||
           type instanceof MongooseBuffer) {
         type = type.toObject({ depopulate: 1 });
-      } else if (type._path)
+      } else if (type._path) {
         type = type.valueOf();
+      } else {
+        // nested object literal
+        type = utils.clone(type);
+      }
 
       if (useSet) {
         if (!('$set' in delta))

diff --git a/test/model.test.js b/test/model.test.js
@@ -800,43 +800,29 @@ module.exports = {
     });
   },
 
-  // gh-662
+  // gh-714
-  'test nested structure created by merging': function() {
+  'modified nested objects which contain MongoseNumbers should not cause a RangeError on save': function () {
-    var db = start();
+    var db =start()
-
-    var MergedSchema = new Schema({
-      a: {
-        foo: String
-      }
-    });
 
-    MergedSchema.add({
+    var schema = new Schema({
-      a: {
+        nested: {
-        b: {
+            num: Number
-          bar: String
         }
-      }
-    });
-
-    mongoose.model('Merged', MergedSchema);
-    var Merged = db.model('Merged', 'merged_' + Math.random());
-
-    var merged = new Merged({
-      a: {
-          foo: 'baz'
-        , b: {
-            bar: 'qux'
-          }
-      }
     });
 
-    merged.save(function(err) {
+    var M = db.model('NestedObjectWithMongooseNumber', schema);
+    var m = new M;
+    m.nested = null;
+    m.save(function (err) {
       should.strictEqual(null, err);
-      Merged.findById(merged.id, function(err, found) {
+
-        db.close();
+      M.findById(m, function (err, m) {
         should.strictEqual(null, err);
-        found.a.foo.should.eql('baz');
+        m.nested.num = 5;
-        found.a.b.bar.should.eql('qux');
+        m.save(function (err) {
+          db.close();
+          should.strictEqual(null, err);
+        });
       });
     });
   },