Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index.d.ts): add CastError constructor #10176

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

michaln-q
Copy link
Contributor

Summary

Should fix #10146

index.d.ts Outdated
@@ -2665,6 +2665,8 @@ declare module 'mongoose' {
path: string;
reason?: NativeError | null;
model?: any;

constructor(type: string, value: any, path: string, reason?: NativeError);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be 1 more parameter: schemaType?: SchemaType . Can you add that please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 5.12.7 milestone Apr 28, 2021
@vkarpov15 vkarpov15 merged commit 33f30b2 into Automattic:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing typescript typings (CastError constructor)
2 participants