Specify connection config via an object and not string

[ad-si]

Sorry if I'm blind, but how can I specify the connection with an object and not a string? E.g.

mongoose.connect({
  username: 'user123',
  password: 'pass123',
  host: 'mongodb0.example.com',
  port: 1234,
})

[IslandRhythms]

Do you mean how is it possible to not use a string or specify the connection string with an object instead of a string?

[ad-si]

Do you mean how is it possible to not use a string or specify the connection string with an object instead of a string?

Yeah, pretty much exactly like in my example

[IslandRhythms]

So there is no native way to do this with mongoose. You could save each part as a variable and concatenate them to achieve a similar effect.

[ad-si]

😳 Wow, I'm baffled that this is not supported yet.
Well then this is a feature request for it. An Object is

1. much easier to handle
2. Can give much better error messages in combination with TypeScript
3. Is the JS default for configuring anything

[ShadiestGoat]

I mean to be fair though, this isn't that hard to implement. My current setup is just get the config, and generate a link using a config

const conf:{
    mongodb: {
        username: string,
        password: string,
        ip: string,
        db: string,
        port: string
    }
} = configFunction()
const MongoDBendPoint = "mongodb://" + conf.mongodb.username + ":" + conf.mongodb.password + "@" + conf.mongodb.ip + ":" + conf.mongodb.port + "/" + conf.mongodb.db + "?readPreference=primary&appname=MyAppNameHere&ssl=false?authSource=" + conf.mongodb.db
//or
const MongoDBendPoint2 = `mongodb://${conf.mongodb.username}:${conf.mongodb.password}@${conf.mongodb.ip}:${conf.mongodb.port}/${conf.mongodb.db}?readPreference=primary&appname=MyAppNameHere&ssl=false?authSource=${conf.mongodb.db}`

[ad-si]

1. Did you handle URL encoding correctly?
2. A lot of invalid values for the parameters could generate a potentially valid MongoDB string. Such things are quite error prone and hard to debug.
3. This code is exceptionally convoluted and ugly. More potential for mistakes. (Would be too long for the common 80 chars limit per line anyways)

What not simply add the function to build this string to mongoose? Including type / range checking, normalization, and so on.

[ShadiestGoat]

I'm not saying it's a perfect solution, I'm just saying that it could be a workaround-ish solution, for now. I'm very not against having this function be in mongoose

[vkarpov15]

Not a bad idea. The only potential downside is that connection string is MongoDB's default approach, so makes it harder to copy/paste connection string from Atlas or Studio 3T. But worth considering for the future.

[ShadiestGoat]

Wait, are you suggesting to replace it completely?

[ad-si]

Well I don't 😳

[vkarpov15]

@ShadiestGoat not suggesting replacing it completely, that would be too big a breaking change for too little benefit IMO. But a named parameters style syntax for connect() might be a good new feature, especially given that MongoDB expects you to escape username/password before putting them into connection strings.

[ShadiestGoat]

Yeah, I no sorry I was a bit worried that you were going to replace it completely, I don't see any benefits to that personally. The connect should be string | loginParams

[ad-si]

Actually, on second thought, I think it would be cleaner to have two functions:

mongoose.connect :: string -> Connection
mongoose.connectConfig :: loginParams -> Connection

[vkarpov15]

Sure, mongoose.connectWithConfig() and Connection#openWithConfig() sounds like a reasonable alternative to avoid too many different overrides for mongoose.connect().