check that schema type is an object when setting isUnderneathDocArray #10361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Originally mentioned here:
#10193 which was (at least partially for us) fixed by @vkarpov15
When checking if
isUnderneathDocArray
should be true for a given schema the root object of a sub document can be just 'nested' and so it throws an error: "Cannot create property '$isUnderneathDocArray' on string 'nested'".This fix just slightly extends the work of @vkarpov15 by adding his fix to
schemaType.schema.paths
andschemaType.schema.subpaths
in addition toschemaType.schema.singleNestedPaths
.More recently mentioned here:
#10357
Examples
Slightly modified version @IslandRhythms example (removed need to connect to db since this happens on schema compilation):