Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 10316: Can now do a dryRun of syncIndexes using Model.diffIndexes() #10362

Merged
merged 9 commits into from
Jun 21, 2021

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

@IslandRhythms IslandRhythms linked an issue Jun 15, 2021 that may be closed by this pull request
test/model.indexes.test.js Show resolved Hide resolved
lib/model.js Outdated Show resolved Hide resolved
@IslandRhythms
Copy link
Collaborator Author

Do you want me to go back in and add the comments to describe what diffIndexes() does or do you got it?

@vkarpov15
Copy link
Collaborator

@IslandRhythms please add comments, that would be very helpful 👍

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this looks great 👍

@vkarpov15 vkarpov15 added this to the 5.13 milestone Jun 21, 2021
@vkarpov15 vkarpov15 changed the base branch from master to 5.13 June 21, 2021 14:39
@vkarpov15 vkarpov15 merged commit eef03f9 into 5.13 Jun 21, 2021
@Uzlopak Uzlopak deleted the feat-10316 branch June 15, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syncIndexes dry-run option
2 participants