Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model): applying object defaults #10442

Merged
merged 2 commits into from
Jul 16, 2021
Merged

fix(model): applying object defaults #10442

merged 2 commits into from
Jul 16, 2021

Conversation

semirturgay
Copy link
Contributor

@semirturgay semirturgay commented Jul 9, 2021 •
edited

Summary
Proof of concept and fix for #10441

Examples
check #10441

@semirturgay semirturgay mentioned this pull request Jul 9, 2021
Closed
@semirturgay semirturgay changed the title test(model): cover applying object defaults DRAFT: test(model): cover applying object defaults Jul 12, 2021
@semirturgay semirturgay changed the title DRAFT: test(model): cover applying object defaults fix(model): applying object defaults Jul 12, 2021
vkarpov15
vkarpov15 requested changes Jul 12, 2021
View reviewed changes
lib/document.js Outdated Show resolved Hide resolved
vkarpov15
vkarpov15 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fix will be in v5.13.3 👍

@vkarpov15 vkarpov15 added this to the 5.13.3 milestone Jul 16, 2021
@vkarpov15 vkarpov15 merged commit 88a32fe into Automattic:master Jul 16, 2021
@nikolasleblanc
Copy link

Hey @vkarpov15, wondering if you have a timeline on when this release might go out? Appreciate your work on this.

@AbdelrahmanHafez AbdelrahmanHafez mentioned this pull request Jul 17, 2021
Merged
@AbdelrahmanHafez
Copy link
Collaborator

@nikolasleblanc FYI, this is released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez requested changes

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.13.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semirturgay @nikolasleblanc @AbdelrahmanHafez @vkarpov15