Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve type checking performance #10536

Closed
wants to merge 1 commit into from
Closed

perf: Improve type checking performance #10536

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 3, 2021

Extends #10515

Summary
Visual Studio code intellicode lags due to the declared Schema Type
for testing the speed of the intellicode i used a simple typescript command as npm run tsc -- --extendedDiagnostics
Steps to reproduce

  • clone the repository at : repro script
  • run npm i
  • then run npm run tsc -- --extendedDiagnostics
    Results (Before):
    image
  • apply the changes in the Pull Request
    Results (After):
    image

This gives me back the snappy intellicode and also doesn't effect the types that much

Examples
Before applying the changes in the Pull Request.

indexjs-simplebot-visual-studio-code-2021-08-03-18-53-07-trim_IcxQNIcW_PNDt.mp4

After applying the changes in the Pull Request.

AFter.mp4

@ghost ghost closed this Aug 4, 2021
@ghost ghost reopened this Aug 4, 2021
@andreialecu
Copy link
Contributor

Note that this change breaks the types, some lines below become invalid/error out.

@vkarpov15 vkarpov15 closed this in fefebb3 Aug 11, 2021
@vkarpov15
Copy link
Collaborator

We made these improvements along with the necessary patches to make our tests pass in fefebb3. Unfortunately this makes our type checking less strict, but the performance impact seems too good to pass up right now. Since our tests all pass, we don't think this change should be backwards breaking, but we'll keep an eye out for any bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants