update type declarations of Schema.index method #10538
Conversation
Raader
changed the title
index.d.ts
Outdated
| @@ -1231,6 +1231,8 @@ declare module 'mongoose' { | |||
| type PreSaveMiddlewareFunction<T> = (this: T, next: (err?: CallbackError) => void, opts: SaveOptions) => void | Promise<void>; | |||
| type PostMiddlewareFunction<ThisType, ResType = any> = (this: ThisType, res: ResType, next: (err?: CallbackError) => void) => void | Promise<void>; | |||
| type ErrorHandlingMiddlewareFunction<ThisType, ResType = any> = (this: ThisType, err: NativeError, res: ResType, next: (err?: CallbackError) => void) => void; | |||
|
|
|||
| type Index = { [key: string]: boolean | number | string | Index } | |||
There was a problem hiding this comment.
Why is this | Index here? I don't know of any recursive index definitions.
There was a problem hiding this comment.
My bad, changed it to mongodb's index type, It's my first ever pr on a project like this. it is not much but it should help with intellisense.
Raader
changed the title
|
This seems to break index creation. |
|
Nevermind, I just realized this was fixed in 5.13.7. Sorry! |
added proper types to arguments of index method on Schema class.